Some deprecation warnings, formal and typo fixes#2505
Merged
Conversation
Collaborator
Author
|
ChatMemberXXX classes also redesigned. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses deprecation warnings, formal improvements, and typo fixes across the codebase. The changes improve code quality by making abstract base classes explicit, adding proper constructor implementations, and cleaning up formatting issues.
- Converts several base classes to proper Abstract Base Classes (ABC) with explicit constructors
- Implements missing
__init__methods for ChatMember subclasses that previously usedpass - Fixes test data and removes trailing whitespace/empty lines
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| tests/test_types.py | Updates test data to use "left" status instead of "administrator" and removes trailing empty lines |
| telebot/types.py | Makes base classes abstract, implements missing constructors, adds deprecation warnings, and improves code formatting |
| telebot/apihelper.py | Adds explicit return statement and improves error handling with proper exception raising |
Comments suppressed due to low confidence (2)
coder2020official
requested changes
Jul 27, 2025
coder2020official
left a comment
coder2020official
left a comment
Collaborator
There was a problem hiding this comment.
Change self.class to type(self)
Collaborator
|
Otherwise lgtm |
Collaborator
Author
|
To be sure you saw it: #2505 (comment) |
Collaborator
|
Yes, understood |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.